Update Helix Job Monitor and turn it on for the runtime pipeline - #131969
Update Helix Job Monitor and turn it on for the runtime pipeline#131969mmitche wants to merge 1 commit into
runtime pipeline#131969Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned .NET local tool version for microsoft.dotnet.helix.jobmonitor to a newer 11.0.0-beta build, so the repo’s dotnet tool restore / Helix job monitor usage picks up the intended fix.
Changes:
- Bump
microsoft.dotnet.helix.jobmonitorfrom11.0.0-beta.26404.8to11.0.0-beta.26406.8in the local tool manifest.
|
Hopefully this will fix the job stuck here https://dev.azure.com/dnceng-public/public/_build/results?buildId=1543009&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=078edc60-2a90-5618-e72d-426a045b11f0 |
|
Tagging subscribers to this area: @dotnet/area-meta |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The Helix Job Monitor version bump is only applied to the local tool manifest here, but the repo still pins Microsoft.DotNet.Helix.JobMonitor to 11.0.0-beta.26404.8 in eng/Version.Details.xml and eng/Version.Details.props (similar tools like XHarness are kept in sync). This leaves two different "source of truth" versions in the repo and can cause confusion / dependency-flow churn; please update the Arcade dependency pins as well (or explain why this tool is intentionally diverging from Version.Details).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26406.8",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title indicates updating helix.jobmonitor to
11.0.0-beta.26406.8, but the tool manifest pins11.0.0-beta.26407.3. Please align the pinned version with the intended update (or update the PR title/description to match) to avoid confusion when tracking tool rollouts.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26407.3",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title says the helix.jobmonitor version is being updated to
11.0.0-beta.26406.8, but the tool manifest is actually updated to11.0.0-beta.26411.1. Please align these (either update the PR title/description to match the version being shipped, or change the version here if26406.8is the intended target).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26411.1",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title says the helix.jobmonitor version is being updated to 11.0.0-beta.26406.8, but this change pins microsoft.dotnet.helix.jobmonitor to 11.0.0-beta.26411.1. Please align the PR title/description with the version actually being used, or update the manifest to the intended version.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26411.1",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- PR title says update helix.jobmonitor to 11.0.0-beta.26406.8, but the actual change sets it to 11.0.0-beta.26411.1 (from 26407.8). Please align the PR title/description with the version being introduced, or adjust the version here to match the stated target.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26411.1",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.config/dotnet-tools.json:30
- The PR title says the Helix job monitor is being updated to 11.0.0-beta.26406.8, but the tool manifest is updated to 11.0.0-beta.31411.1. Please align the PR metadata and the actual version being consumed (either update the title/description or change the manifest version) so it’s clear what build is being taken and why.
"version": "11.0.0-beta.31411.1",
NuGet.config:15
- Adding the new 'general-testing' package source affects restores for the entire repo (extra feed to probe and a potentially different source of packages). If this feed is only needed to acquire the updated helix.jobmonitor tool, consider scoping it to just that restore path (or document why the global source addition is required) to avoid unintended restore/source selection changes.
<add key="general-testing" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/general-testing/nuget/v3/index.json" />
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title/description says the update is to helix.jobmonitor 11.0.0-beta.26406.8, but the change here updates to 11.0.0-beta.31411.2 (from 11.0.0-beta.26407.8). Please confirm which version is intended and align either this value or the PR metadata so the change is traceable.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.2",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:58
enableHelixJobMonitoris defined twice in the samevariables:block (firstfalse, thentrue). In Azure Pipelines the later definition wins, so this effectively forces the monitor on for all runs, and the earlier entry is just confusing/noise.
If the intent is to force-enable the monitor, consider collapsing this to a single definition (and update the comment accordingly) so the effective value is obvious.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:31
- The PR title says this updates
helix.jobmonitorto11.0.0-beta.26406.8, but the tool manifest pinsmicrosoft.dotnet.helix.jobmonitorto11.0.0-beta.31411.14(and the previous value was11.0.0-beta.26411.119, which is already newer than26406.8).
Please confirm the intended version and update either the PR title/description or the pinned tool version so they match.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.14",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:59
- The pipeline defines enableHelixJobMonitor twice (first false, then true), so the earlier assignment is overridden and effectively dead. This is confusing and the accompanying comment is misleading; prefer a single definition that clearly overrides the default from common/variables.yml.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:30
- The PR title says this updates microsoft.dotnet.helix.jobmonitor to 11.0.0-beta.26406.8, but the tool manifest is pinned to 11.0.0-beta.31411.15. Please align the PR title/description with the actual version (or adjust the pinned version if the title is the intended target).
"version": "11.0.0-beta.31411.15",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:58
enableHelixJobMonitoris assigned twice with conflicting values (false then true). Since there are no uses between these assignments, the first assignment is redundant and makes it harder to understand which behavior is intended.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:30
- The PR title/description says the helix job monitor is being updated to
11.0.0-beta.26406.8, but this change pinsmicrosoft.dotnet.helix.jobmonitorto11.0.0-beta.31411.16. Please reconcile the intended version (or update the PR title/description to match what is actually being used).
"version": "11.0.0-beta.31411.16",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:58
- The variable
enableHelixJobMonitoris declared twice (firstfalse, thentrue). In Azure Pipelines the later value wins, which makes the earlier entry misleading and easy to accidentally “toggle” without effect. Consider keeping a single declaration with the intended value and keephelix-platforms.ymlas a separate entry.
- name: enableHelixJobMonitor
value: false
- template: /eng/pipelines/helix-platforms.yml
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:31
- The PR title says the job monitor is being updated to
11.0.0-beta.26406.8, but the manifest pinsmicrosoft.dotnet.helix.jobmonitorto11.0.0-beta.31411.17. Please align the pinned version (and any related feed changes) with the intended version, or update the PR title/description accordingly.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.17",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
eng/pipelines/runtime.yml:58
enableHelixJobMonitoris defined twice in the same variables block. The second definition currently overrides the first, making the initialfalseassignment redundant and potentially confusing (and order-dependent for template evaluation). Prefer a single definition with the effective value.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
mmitche
changed the title
Use the promoted scalable Job Monitor, add configurable result-upload parallelism, and enable the monitor in the runtime pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f6ec29d9-df3d-405a-a823-571c6a18e447
6a4a54e to
dd396ca
Compare
premun
changed the title
runtime pipeline
Summary
Microsoft.DotNet.Helix.JobMonitorto11.0.0-beta.26424.2from Arcade build20260824.248